Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to filter for pods and services in any namespace #1308

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add flags to filter for pods and services in any namespace #1308

merged 1 commit into from
Jan 9, 2024

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Dec 1, 2023

This PR introduces to-all-namespaces, from-all-namespaces, and all-namespaces flags that allow filtering for services and pods in all namespaces.

This allows us to for example list any flows to a service named bar in any namespace using

hubble observe --all-namespaces --service bar

This PR builds on cilium/cilium#28921

Closes: #359

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Dec 1, 2023
@glrf glrf force-pushed the feat/all-namespaces branch 4 times, most recently from 45d6448 to 2446870 Compare December 1, 2023 14:51
@glrf glrf marked this pull request as ready for review December 1, 2023 15:12
@glrf glrf requested review from a team as code owners December 1, 2023 15:12
@glrf glrf requested review from rolinh and removed request for a team December 1, 2023 15:12
@kaworu kaworu self-requested a review December 4, 2023 09:23
@kaworu kaworu added ⌨️ area/cli Impacts the command line interface of any command in the repository. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Dec 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Dec 4, 2023
@glrf
Add flag to filter for pods and services in all namespaces
c6d312b 
We introduce `to-/from-/all-namespaces` flags that allow filtering for
services and pods in all namespaces.

Signed-off-by: Fabian Fischer <[email protected]>
@glrf glrf force-pushed the feat/all-namespaces branch from 2446870 to c6d312b Compare December 8, 2023 09:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 9, 2024
@rolinh rolinh merged commit 5f6f538 into cilium:main Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--namespace is incompatible with --pod
3 participants
@glrf @kaworu @rolinh