update Go to v1.23.6 and fix Renovate handling of Go #1650
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go image is supposedly updated by Renovate. However, by being too specific with the Alpine version, we stopped getting updates as an Alpine v3.19 image is no longer being published. To avoid this issue, let's simply specify `-alpine` as the image without specifying the version. There's no point in being too specific as we do not use this image for a multi-strage docker build. Signed-off-by: Robin Hahling <[email protected]>
There's a case for being conservative with the required version when a module is imported by others. Given that now, 99.9% of Hubble's code lives in github.com/cilium/cilium, there's no point trying to require the .0 version. The main driver for the change is that our CI jobs use the Go version as specified in the `go.mod` file. With this change, we can now let Renovate update the Go version in the go.mod file automatically. Signed-off-by: Robin Hahling <[email protected]>
rolinh
added
the
release-note/minor
kaworu
approved these changes
Feb 10, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.