refactor: convert plpgsql functions to SQL for inlining #158
+49
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert 7 simple wrapper functions from plpgsql to SQL language to enable PostgreSQL query planner to inline them, improving performance. Functions converted: - eql_v2.to_encrypted(jsonb) - cast JSONB to encrypted type - eql_v2.to_encrypted(text) - cast text to encrypted type - eql_v2.to_jsonb(eql_v2_encrypted) - extract JSONB from encrypted type - eql_v2.ciphertext(eql_v2_encrypted) - extract ciphertext wrapper - eql_v2.meta_data(jsonb) - extract metadata from JSONB - eql_v2.meta_data(eql_v2_encrypted) - extract metadata wrapper - eql_v2.compare_literal() - literal comparison for btree fallback All functions are marked STRICT, making NULL checks in plpgsql code redundant. SQL language functions are eligible for inlining by the query planner, while plpgsql functions are always treated as opaque function calls. Files modified: - src/encrypted/casts.sql (3 functions) - src/encrypted/functions.sql (3 functions) - src/encrypted/compare.sql (1 function)
Document when to use LANGUAGE SQL vs LANGUAGE plpgsql for PostgreSQL functions. SQL is preferred for simple functions due to inlining benefits and better index performance. PL/pgSQL should be used when procedural features (variables, exception handling, loops, dynamic SQL) are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
PostgreSQL can inline simple SQL functions into calling queries, eliminating function call overhead. This is particularly important for functions used in index expressions (GIN indexes) where the function is called on every row insert/update.
Test plan