-
Notifications
You must be signed in to change notification settings - Fork 0
feat: cipherstash-proxy helm chart #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, but LGTM
- name: metrics | ||
containerPort: 9930 | ||
protocol: TCP | ||
env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding some of the logging options here?
Important ones would be:
CS_LOG__FORMAT
CS_LOG__LEVEL
If it works like docker-compose.yml
the env options need to be explicitly declared or they are not passed through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some TLS config settings too that might be worth adding
@tobyhede All your points are valid I've created follow up action items to address them |
Adds a helm chart for deploying Proxy to a K8s cluster:
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.