Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

fix: provider as tenant login #820

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: provider as tenant login #820

merged 3 commits into from
Sep 11, 2024

Conversation

sbasan
Copy link
Contributor

@sbasan sbasan commented Sep 11, 2024

Pull Request summary:

Authentication fixes and improvements

Description of changes:

  • fix 409 during provider-as-tenant login due to incorrect vManageAuth implementation
  • further decoulpe auth from ManagerSession
  • unify auth requests logging (anonymized)
  • provide detailed auth request logging when catalystwan_auth_trace environment variable is set

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@sbasan sbasan force-pushed the fix/provider-as-tenant-login branch 2 times, most recently from 4aab8ca to 3bffdb7 Compare September 11, 2024 12:18
@sbasan sbasan force-pushed the fix/provider-as-tenant-login branch from 3bffdb7 to eec2219 Compare September 11, 2024 12:30
@sbasan sbasan marked this pull request as ready for review September 11, 2024 12:52
@sbasan sbasan requested a review from jpkrajewski September 11, 2024 12:52
smialy
smialy previously approved these changes Sep 11, 2024
@sbasan sbasan merged commit 1949b59 into main Sep 11, 2024
11 checks passed
@sbasan sbasan deleted the fix/provider-as-tenant-login branch September 11, 2024 13:50
sbasan added a commit that referenced this pull request Sep 11, 2024
* draft

* bump version

* update env variables usage
sbasan added a commit that referenced this pull request Sep 11, 2024
* Merge pull request #795 from cisco-open/apigw

Add API GW login. Refactor session related files.

* Added validation activities when TaskValidationError is raised

* Bump actions/setup-python from 5.1.1 to 5.2.0 (#809)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@39cd149...f677139)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* creating new radius and tacacs data classes  (#815)

* updating radius and tacacs data classes for new changes

* fix static

* fix static

* make vpn vpn id optional

* sub class

* match with parent class

* match with parent class

* match with parent class

* snake case

* description

* src checks

* src checks

* src checks

* Add staging

* bump up version

* fix: provider as tenant login (#820)

* draft

* bump version

* update env variables usage

* bump dev version 0.35.3dev0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jakub Krajewski <[email protected]>
Co-authored-by: Bartlomiej Radwan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: nikhilkp93 <[email protected]>
Co-authored-by: Jakub Krajewski <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants