Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

auth: refactor #824

Merged
merged 3 commits into from
Sep 12, 2024
Merged

auth: refactor #824

merged 3 commits into from
Sep 12, 2024

Conversation

sbasan
Copy link
Contributor

@sbasan sbasan commented Sep 12, 2024

Pull Request summary:

vManageAuth refactor

Description of changes:

  • fix 409 when VSessionId was not properly refreshed after JSESSIONID updated
  • fix infinite auth loop when vAnalytics enabled
  • VSessionId flow for provider-as-tenant is now separate AuthBase class instead part of login() method

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@sbasan sbasan force-pushed the sbasan/auth-refactor branch from ef3f5ff to 7523a29 Compare September 12, 2024 18:48
@sbasan sbasan marked this pull request as ready for review September 12, 2024 19:02
@nikhilkp93 nikhilkp93 merged commit 27b9cf3 into main Sep 12, 2024
11 checks passed
@nikhilkp93 nikhilkp93 deleted the sbasan/auth-refactor branch September 12, 2024 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimOverholt JimOverholt JimOverholt approved these changes

@nikhilkp93 nikhilkp93 nikhilkp93 approved these changes

@jpkrajewski jpkrajewski Awaiting requested review from jpkrajewski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbasan @JimOverholt @nikhilkp93