Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

dev: Fix bgp, ethernet #831

Merged
merged 3 commits into from
Sep 24, 2024
Merged

dev: Fix bgp, ethernet #831

merged 3 commits into from
Sep 24, 2024

Conversation

jpkrajewski
Copy link
Collaborator

@jpkrajewski jpkrajewski commented Sep 23, 2024 •
edited
Loading

Pull Request summary:

  • Fix type annotation for BGP
  • Fix model_config field for wan ethernet

Description of changes:

[Add more in depth analysis of what changed, provide logs, examples of usage]

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@jpkrajewski jpkrajewski requested a review from sbasan September 23, 2024 13:00
@jpkrajewski jpkrajewski changed the title dev: Fix bgp dev: Fix bgp, ethernet Sep 24, 2024
@jpkrajewski jpkrajewski marked this pull request as ready for review September 24, 2024 12:38
@jpkrajewski jpkrajewski merged commit 536473f into dev Sep 24, 2024
11 checks passed
@jpkrajewski jpkrajewski deleted the fix/model-fixes branch September 24, 2024 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbasan sbasan sbasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpkrajewski @sbasan