This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
dev: support AppRoute policy #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrajewski
reviewed
Oct 9, 2024
| preferred_color_group: Optional[UUID] = None, | ||
| ) -> None: | ||
| if preferred_color is not None: | ||
| action = SlaClassAction().from_params( |
There was a problem hiding this comment.
Suggested change
| action = SlaClassAction().from_params( | |
| action = SlaClassAction.from_params( |
There was a problem hiding this comment.
NIT: from_params is static method
catalystwan/models/configuration/feature_profile/sdwan/application_priority/traffic_policy.py
Outdated
Show resolved
Hide resolved
Comment on lines
1054
to
1059
| if not_met_action is not None: | ||
| action.parameter.append(SlaNotMet(field=not_met_action)) | ||
| if preferred_color is not None: | ||
| action.parameter.append(SlaPreferredColor(value=preferred_color)) | ||
| if preferred_color_group is not None: | ||
| action.parameter.append(SlaPreferredColorGroup(ref=preferred_color_group)) |
There was a problem hiding this comment.
Suggested change
| if not_met_action is not None: | |
| action.parameter.append(SlaNotMet(field=not_met_action)) | |
| if preferred_color is not None: | |
| action.parameter.append(SlaPreferredColor(value=preferred_color)) | |
| if preferred_color_group is not None: | |
| action.parameter.append(SlaPreferredColorGroup(ref=preferred_color_group)) | |
| if not_met_action: | |
| action.parameter.append(SlaNotMet(field=not_met_action)) | |
| if preferred_color: | |
| action.parameter.append(SlaPreferredColor(value=preferred_color)) | |
| if preferred_color_group: | |
| action.parameter.append(SlaPreferredColorGroup(ref=preferred_color_group)) |
There was a problem hiding this comment.
NIT: Can just check for truthiness
jpkrajewski
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
appRoutepolicy definitiontraffic-policyparcel dscp match fieldtraffic-policyactionsChecklist: