Skip to content

Conversation

@osajulian-dev
Copy link
Contributor

Description

This PR adds a new auto_confirm_sns_subscription flag to conditionally auto-confirm SNS email subscriptions using the endpoint_auto_confirms attribute in Terraform.

Specifically:

  • Adds a new auto_confirm_sns_subscription boolean variable (default: false)
  • Applies this flag to the aws_sns_topic_subscription.civiform_alert_subscription resource
  • Removes previously deployed test Lambda resources for auto-confirmation
  • Ran terraform plan with auto_confirm_sns_subscription=true to verify it triggers a PendingConfirmation subscription without errors

Checklist

General

  • Added the correct label
  • Assigned to a specific person or civiform/deployment-system
  • Created tests which fail without the change (if possible)
  • Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)
  • Extended the README / documentation, if necessary

Instructions for manual testing

In your Terraform plan command, pass in:
-var='auto_confirm_sns_subscription=true'
-var='civiform_alarm_email="[email protected]"'

Issue(s) this completes

Fixes #10816

@osajulian-dev osajulian-dev requested a review from dkatzz July 1, 2025 01:31
@osajulian-dev osajulian-dev added the enhancement New feature or request label Jul 1, 2025
@osajulian-dev osajulian-dev self-assigned this Jul 1, 2025
osajulian-dev and others added 9 commits July 16, 2025 14:32
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@osajulian-dev osajulian-dev force-pushed the feature/auto-confirm-flag-for-alert-subscription branch from 41d6a7a to 21c7d71 Compare July 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants