Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove level_id From Table #75

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

cjmellor
Copy link
Owner

@cjmellor cjmellor commented Apr 8, 2024

Description

Removes the level_id column from the Users' table. It wasn't used.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

n/a

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

The level_id column has been eliminated from the user's table, and all code references to this column have been adjusted accordingly. Now, the user's level information is accessed directly from the user's experience, improving data relations and reducing redundancy. As a result, code consistency and performance may be enhanced.
The method 'level' has been removed from GiveExperience model to reduce complexity. Instead, only 'experience' is now queried in the LeaderboardService to maintain necessary functionality and enhance performance.
@cjmellor cjmellor added the enhancement New feature or request label Apr 8, 2024
@cjmellor cjmellor self-assigned this Apr 8, 2024
@cjmellor cjmellor merged commit 8d6a5cd into main Apr 9, 2024
5 of 14 checks passed
@cjmellor cjmellor deleted the refactor/remove-level-id-column-from-users-table branch April 9, 2024 17:23
@xmuntane xmuntane mentioned this pull request Apr 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant