Working Build for more than Gren, Formatting, Readme Cleanup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this updates the README.md to be a little bit more representative of what's actually happening (and look a bit nicer). second i applied code style to the actual code that's written right now (sysmodule). the closest to code that Gren actually wrote (and wasn't generated/copied from elsewhere) seemed to be WebKit so I chose that as the style, but we can obviously change super easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just what I got too while looking at this during work meetings today. Booted it up on atmosphere, and SplitNX folder was created, and it built. So I assume everything is properly working (though I didn't actually live split it). Figured I'd push up for you to test as well, since you probably know what's expected more.
The build didn't work
make distwasn't a real thing, andmakefailed due to a bad header include path. I've attempted to recreate amake distthat should offer the same experience, but withoutmake distexisting in current HEAD i just sort of guessed at what it "probably did".Readme now has a little bit more instructions (splitting up build/use), and documents all of the commands I noticed the sysmodule had.
I added just a small logging library rather than manually jugging std::fstreams, just cause as I wanted to take a look for autosplitting more than just a textfile of memory, probably gonna want some more logging. If this solutions isn't up to par, I can rework.
Finally I added a
make stylefor using clang-format to help enforce a consistent style as the mismash was giving me whiplash. I chose webkit cause that seemed to be the closest built in default to the code you wrote (and not the ones that like dkp generated), but happy to also change that to a different formatter if you wanna follow a separate style.