Add support for github enterprise#145
Closed
everpcpc wants to merge 2 commits intoclaudioc:masterfrom
Closed
Conversation
lib/config.js
Outdated
Owner
There was a problem hiding this comment.
I think that for the default values, either you leave it really empty or you use those default URLs. The strings as they are, are a bit confusing, IMHO.
Contributor
Author
There was a problem hiding this comment.
moved the descriptions to readme
Contributor
Author
|
But there seems something wrong using the github enterprise auth. (While the default github.com works well.) It seems the |
Contributor
Author
|
close for #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see also: https://github.com/jaredhanson/passport-github/blob/master/lib/strategy.js#L53
passport-github allows passing these options to support a private github enterprise instance.