Open
Conversation
Owner
|
Hi @xgvargas good idea! Together with its markdown parser, the syntax highlighter is definitely something Jingo needs to improve upon. I'd totally consider merging this PR: I just need to take a look at the changes I need to do at CSS level (as you mentioned) and think about any "breaking changes" we might introduce (you know, the problem when changing something "low level" is to guarantee not to break how people are already using Jingo). Changing the syntax highlighter should be much easier than changing the markdown intepreter, though. I will keep you posted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, First of all I have to say I love to use Jingo for documenting our work. But in my current project I use lots of YAML and the 5 years old
node-syntaxhighlighteris not able to deal with it. Acctually it can handle a very small number of languages, so I've made this PR wich adds support forhightligh.jsfor jingo with more then 127 languages and many styles (but current code has a hard coded style, I can add a config property for this IF you this this PR is worth).