Check wiki page existence server-side#96
Open
ryanvarick wants to merge 1 commit intoclaudioc:masterfrom
ryanvarick:server_existence_check
Open
Check wiki page existence server-side#96ryanvarick wants to merge 1 commit intoclaudioc:masterfrom ryanvarick:server_existence_check
ryanvarick wants to merge 1 commit intoclaudioc:masterfrom
ryanvarick:server_existence_check
Conversation
Owner
|
Hi, mmmh, it's apparently a good idea. I need to take a look at how much it would cost performance wise, though. If I get it right, this change would affect how the page is rendered. My original idea (the idea of the test for the presence of a page being on the client side), is that the user should be able to read the page as soon as possible and have the browser work in background retrieving the informations for the missing links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to eliminate as much client-side javascript as I can. There's probably a better way to do this, but this was the least invasive change.