-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use family_id and external_rev_id to detect GFX11/RDNA3, Raphael APU, Me… #154
Conversation
getfamily_from_id should be called inside getfamily, otherwise the mem path may fail. family_id and and chip_external_rev do not need to be exported - they can be removed from the header and marked static inside the file. However, I'm not sure I want to use this general approach. First of all it seems like manual updates would be needed every time, when until now it was 90% scripted. Second those GFX62432 names are quite ugly and nobody can interpret what they mean. |
On the tech side, I forgot to say the GFX defines should also be inside amdgpu.c. |
Scripting may be possible since the Since AMDGPU drivers no longer require DeviceID, other methods will be needed to update the database in the future.
In terms of code names, it seems to me that it is no different than any other. Mesa3D has dropped the color and fish names and uses names like Navi21 , but radeontop continues to use color and fish names. |
Changed: ab7a242 |
There is also the option of using marketing names instead of code names. https://gitlab.freedesktop.org/mesa/drm/-/blob/main/amdgpu/amdgpu_device.c#L293-299 |
Close PR due to no progress. I will prioritize the development of alternatives. |
…ndocino APU
family_id
andexternal_rev_id
can be used to identify most AMD GPUs, but for now use them for GPUs that are not in the database.Resolve #151
Resolve #153
Reference