Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navi31 pci id #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add navi31 pci id #165

wants to merge 1 commit into from

Conversation

wgottwalt
Copy link

adds PCI id for NAVI31 (several Radeon RX 7900 XT, XTX and M)

@clbr
Copy link
Owner

clbr commented Mar 13, 2024

Please see the reply in #159.

@wgottwalt
Copy link
Author

Your approach using this script is a bit naive. The AMDGPU driver is half PCI and half platform driver. The platform part initializes the driver using the Radeon ATOM bios and if available the PSP (platform security processor since the first Ryzen gen). These parts don't require PCI ids from the driver, they get all information from the binary blobs. This is the case since NAVI2x. In short: Your script will never work again and you need to change how this part is done in radeontop, like manually adding PCI ids - what I did - or scan the PCI id database provided by libpciaccess, or better, do detecting via libpciaccess entirely.

@clbr
Copy link
Owner

clbr commented Mar 14, 2024

In short: Your script will never work again

I know? Looks like you didn't check the existing issues and PRs.

you need to change how this part is done in radeontop

Nope. I don't much care about cards 10 years newer than what I have.

@wgottwalt
Copy link
Author

Yeah, you are right, I didn't check. Didn't thought I have to put so much time in it.

That is actually a pity. The other option is amdgpu_top, but having a 13+ mb binary for such a tool is, uhm, lets call it insane. Though, thx for the honesty, it is so much better than coming up with some odd excuse. Hehe, it is actually funny, would have said the same in this situation. XD

@clbr
Copy link
Owner

clbr commented Mar 14, 2024 via email

@wgottwalt
Copy link
Author

I was thinking about some more practical, like dropping this list entirely and switch to libpciaccess. Not sure yet if I will add this to radeontop or write a new tool for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants