Add a build option for transparent background #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ncurses docs state that to use color -1, you must first call use_default_colors. I also think that this doesn't need to be an option at all, but replacing the BLACK color with -1 should work in most terminals. |
gpollo
commented
Jun 29, 2017
| @@ -91,11 +91,20 @@ void present(const unsigned int ticks, const char card[], unsigned int color) { | |||
| clear(); | |||
|
|
|||
| start_color(); | |||
| #ifdef ENABLE_TRANSPARENT | |||
| use_default_colors(); | |||
There was a problem hiding this comment.
use_default_colors is being called here. And yeah, I don't really if it's a good thing to default to -1 tho.
|
After some testing, always enabling transparency works fine under TTY, but I believe it is a matter of taste whether one wants transparency (it just looked great with my background under X desktop). |
|
None of my terminals use compositing, and under all of them -1 is just the default bg color (black for all but xterm, which is white). So please make it the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to build the application with background transparency using
make transparent=1.