Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TLM] Add similarity measure option #351

Merged
merged 4 commits into from
Jan 27, 2025
Merged

[TLM] Add similarity measure option #351

merged 4 commits into from
Jan 27, 2025

Conversation

huiwengoh
Copy link
Contributor

No description provided.

@huiwengoh huiwengoh requested a review from jas2600 January 24, 2025 23:49
@github-actions GitHub Actions
Copy link

Ensure final changes made to the TLM code are tested before merging. To run the TLM tests, comment /test-tlm on this PR. To re-run failed property tests, comment /rerun-failed-test-tlm instead.

@huiwengoh
Copy link
Contributor Author

huiwengoh commented Jan 27, 2025 •
edited by github-actions bot
Loading

/test-tlm
✨ Starting TLM tests... ✨
If you want to run all the TLM tests again (because TLM code is ready for review), comment '/test-tlm' on this PR.
If you want to re-run only the failed tests (you are still developing), comment '/rerun-failed-test-tlm' on this PR.
View full GitHub Actions run log
✨ Tests completed! ✨
TLM Tests Results: ❌❌❌❌❌
TLM Property Tests Results: ✅✅✅✅✅
Click the Github Actions run log for more information.
✨ Tests completed! ✨
TLM Tests Results: ✅✅✅✅✅
TLM Property Tests Results: ✅✅✅✅✅
Click the Github Actions run log for more information.

@github-actions GitHub Actions
Copy link

Ensure final changes made to the TLM code are tested before merging. To run the TLM tests, comment /test-tlm on this PR. To re-run failed property tests, comment /rerun-failed-test-tlm instead.

@huiwengoh
Copy link
Contributor Author

huiwengoh commented Jan 27, 2025 •
edited by github-actions bot
Loading

/test-tlm
✨ Starting TLM tests... ✨
If you want to run all the TLM tests again (because TLM code is ready for review), comment '/test-tlm' on this PR.
If you want to re-run only the failed tests (you are still developing), comment '/rerun-failed-test-tlm' on this PR.
View full GitHub Actions run log
✨ Tests completed! ✨
TLM Tests Results: ✅✅✅✅✅
TLM Property Tests Results: ✅✅✅✅✅
Click the Github Actions run log for more information.

@github-actions GitHub Actions
Copy link

Ensure final changes made to the TLM code are tested before merging. To run the TLM tests, comment /test-tlm on this PR. To re-run failed property tests, comment /rerun-failed-test-tlm instead.

@github-actions GitHub Actions
Copy link

Ensure final changes made to the TLM code are tested before merging. To run the TLM tests, comment /test-tlm on this PR. To re-run failed property tests, comment /rerun-failed-test-tlm instead.

@huiwengoh huiwengoh merged commit 9446669 into main Jan 27, 2025
7 checks passed
@huiwengoh huiwengoh deleted the tlm-similarity-measure branch January 27, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jas2600 jas2600 jas2600 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huiwengoh @jas2600