-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origins/condaforge Route for Consistent Conda API Structure #1279
Add origins/condaforge Route for Consistent Conda API Structure #1279
Conversation
test/lib/condaRepoAccess.js
Outdated
}) | ||
}) | ||
|
||
describe('Conda Origin Routes', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_getOriginCondaRevisions is exposed on the router for testing purposes. Tests related to "Conda Origin Routes" may be better to remain in origin related tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice refactor. The descriptions in the issue and this PR made it easy to review. Thanks!
Description:
This pull request addresses the need to enhance the API for Conda origins by creating a separate route for the Conda-Forge channel, thereby aligning it with the structure used for other package managers.
Key Changes:
origins/condaforge
Route:/origins/condaforge
.CondarepoAccess
library for better separation of concerns and reusability.originConda
and neworiginCondaforge
routes to useCondaRepoAccess
for accessing package data.Files Changed:
app.js
: Added route definition for Conda-Forge.lib/condaRepoAccess.js
: New library for handling Conda repository access.routes/originConda.js
: Refactored to leverageCondaRepoAccess
.routes/originCondaforge.js
: New route handler for Conda-Forge channel.test/lib/condaRepoAccess.js
: Added unit tests forCondaRepoAccess
.test/routes/origins.js
: Updated integration tests to accommodate new and refactored routes.Notes:
This PR is related to #1284