Update RedisCache and rate limit related libraries #1290
Conversation
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
from
2b9af0b to
e3d72a2
Compare
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
6 times, most recently
from
10144c4 to
1ffe770
Compare
The application test starts a timer on the curation queue. This timer is not cleaned up, which causes intermittent failures in the "Curation queue processing" unit tests. Disable the unit test.
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
from
1ffe770 to
d0160f4
Compare
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
from
f7150d5 to
99a9aa4
Compare
bin/www
Outdated
| const cachingService = config.caching.service() | ||
| await Promise.all([cachingService.initialize()]).catch(error => { | ||
| logger.error('Error connecting to cachingService', error) | ||
| process.exit(1) |
There was a problem hiding this comment.
Fail fast here when redis fails to connect during startup. In the event of this happens, we have the option to update configuration to use in-memory caching for deployment as a fallback. Another option is to increase the connection timeout. Currently, default value is used here, same as the original code. Any thoughts?
There was a problem hiding this comment.
Problem is that while you wait for connection, your service is not exposing any endpoint. How do you deal with the cloud probes ?
test/app.js
Outdated
| }) | ||
|
|
||
| it.skip('should initialize', done => { | ||
| const app = Application(config, { |
There was a problem hiding this comment.
This test starts several timers, one of which operates on the curation queue. The timers are not properly cleaned up and interfere with the curation unit tests. Disabled the test for now.
bin/www
Outdated
| const cachingService = config.caching.service() | ||
| await Promise.all([cachingService.initialize()]).catch(error => { | ||
| logger.error('Error connecting to cachingService', error) | ||
| process.exit(1) |
There was a problem hiding this comment.
Problem is that while you wait for connection, your service is not exposing any endpoint. How do you deal with the cloud probes ?
test/app.js
Outdated
| }) | ||
|
|
||
| it.skip('should initialize', done => { | ||
| const app = Application(config, { |
| debug: () => {}, | ||
| error: () => {}, | ||
| info: () => {} |
There was a problem hiding this comment.
Since it is static, why not setting those line 348 ?
|
@qtomlinson I am not familiar enough with the project to approve all the changes but we had a great discussion on the app startup. |
… middleware Restored the integration test code for app. The test itself is still disabled because createApp starts recursive timers, which interfere with other unit tests.
|
@ArnaudBuchholz Thanks so much for your feedback! I really enjoyed our discussion. |
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
from
fc59b7f to
357f8fa
Compare
qtomlinson
force-pushed
the
qt/update_ratelimit
branch
from
357f8fa to
f101ef3
Compare
This PR addresses the upgrade of our Redis and rate-limiting libraries, which had breaking changes. The following are the specific modifications and improvements made:
Refactor Rate Limiting Logic to
ratelimit.jsratelimit.jsmodule for better encapsulation and to facilitate unit testing.Reduced the number of Redis clients from three to one
Standardization of Rate Limiting Headers
standardHeadersinstead of legacy headers. This is a breaking change that may affect clients using the old rate-limit headers.Addition of Unit and Integration Tests