Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support license edit #980

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Support license edit #980

merged 3 commits into from
Jun 1, 2022

Conversation

qtomlinson
Copy link
Collaborator

Task: #955

@netlify
Copy link

netlify bot commented May 9, 2022 •
edited
Loading

✅ Deploy Preview for blissful-goodall-fa23f6 ready!

Name Link
🔨 Latest commit d882806
🔍 Latest deploy log https://app.netlify.com/sites/blissful-goodall-fa23f6/deploys/628d3b13f161140008531fab
😎 Deploy Preview https://deploy-preview-980--blissful-goodall-fa23f6.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@qtomlinson
Copy link
Collaborator Author

@disulliv @mpcen ready for review :)

@disulliv
Copy link
Contributor

Code looked good to me! @qtomlinson do you have any screenshots from testing it?

@qtomlinson
Copy link
Collaborator Author

Before Edit
image
Edit
image
After Edit
image

mpcen
mpcen requested changes May 20, 2022
View reviewed changes
src/components/FileList/FileList.js Outdated Show resolved Hide resolved
src/components/FileList/FileList.js Outdated Show resolved Hide resolved
@disulliv disulliv merged commit 8ac858f into clearlydefined:master Jun 1, 2022
@disulliv disulliv mentioned this pull request Jun 2, 2022
Merged
@qtomlinson qtomlinson deleted the qt/edit_license branch June 3, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpcen mpcen mpcen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qtomlinson @disulliv @mpcen