Support edit in Quick Edit Model #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-add handleSaveEdit -display the changes correctly with original values in tool tip Task: clearlydefined#956
-SourceLocationPicker is the presentation UI -SourcePicker is the container, containing the state and on change handlers
SourceLocationPicker -sync activeProvider with props to handle display of non github source location -add an internal state of selected component. No need to pass in selected component from props (to simplify the interface with containers). Integrate SourceLocationPicker in QuickEditModel -also adjust styling so SourceLocationPicker looks ok inside QuickEditModel -support saving source location edit
To allow contribution from the main page after editting.
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Moved source-picker id tag to inside SourceLocationPicker The container padding related css is moved outside the #source-picker block.
|
Quick Edit Model integrated with SpdxPicker and SourceLocationPicker |
|
After edit in workspace page |
|
It is noted that there are three ways to edit a component currently:
In addition, behaviour after edit at the three places look different as well. In workspace page (PageDefinition), components are refreshed after contributions; whereas refresh does not happen after contribution in PageBrowse or FullDetailPage. This can be another future topic to look into. |
|
Screenshot for after edit in main page (PageBrowse). Contribute button is available for curation. |
disulliv
reviewed
Jun 20, 2022
qtomlinson
commented
Jun 20, 2022
|
@disulliv any more improvements needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ui support to allow edit in Quick Edit Model.
Also added buttons in PageBrowse (main page) to allow contribution after edit.
Task: #956