Polish pass on the Spanish translation#498
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I see there's CI failures when checking the trait references: From my (superficial) understanding of the project, I thought only the trait name needed to match, not the aura/pulse part inside of the brackets, so I translated those for clarity. |
|
Thanks! The CI checks have been expanding as I'm relying on them more, in place of data validation checks in the spreadsheet I was using for data entry. Anyway, I'm happy to support whatever level of translation people think is appropriate, and I'll change the tests to allow what you've done here. |
|
Brilliant thanks! I do think the aura and pulse translations help in making these feel more natural, yes. |
This massively expands on the work done in #491. I repeatedly went over every single rule, the different game terms, phrase wordings, etc., and made the translation be as consistent both internally and with the english translation as possible, including which terms are kept in english and which are translated. Along the way I fixed some semantic discrepancies as well.
I believe the resulting translation is now of high enough quality to be used in competitive settings.
I also fixed an instance in the enlish version where the text was missing a period at the end of a sentence.