Skip to content

Polish pass on the Spanish translation#498

Merged
cleech merged 3 commits intocleech:preview-srcfrom
nventuro:preview-src
Mar 30, 2026
Merged

Polish pass on the Spanish translation#498
cleech merged 3 commits intocleech:preview-srcfrom
nventuro:preview-src

Conversation

@nventuro
Copy link
Copy Markdown
Contributor

This massively expands on the work done in #491. I repeatedly went over every single rule, the different game terms, phrase wordings, etc., and made the translation be as consistent both internally and with the english translation as possible, including which terms are kept in english and which are translated. Along the way I fixed some semantic discrepancies as well.

I believe the resulting translation is now of high enough quality to be used in competitive settings.

I also fixed an instance in the enlish version where the text was missing a period at the end of a sentence.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f23d906c-67fb-4ead-b4f7-7062bc8bfb04

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nventuro
Copy link
Copy Markdown
Contributor Author

I see there's CI failures when checking the trait references:

# Validating translation integrity against GB-Playbook-4-8.json ❌
  Value mismatch at Models[1].character_traits[2]: expected Watch The World Burn [4″ Pulse], got Watch The World Burn [Pulso de 4″]

From my (superficial) understanding of the project, I thought only the trait name needed to match, not the aura/pulse part inside of the brackets, so I translated those for clarity.

@cleech
Copy link
Copy Markdown
Owner

cleech commented Mar 27, 2026

Thanks! The CI checks have been expanding as I'm relying on them more, in place of data validation checks in the spreadsheet I was using for data entry. Anyway, I'm happy to support whatever level of translation people think is appropriate, and I'll change the tests to allow what you've done here.

@nventuro
Copy link
Copy Markdown
Contributor Author

Brilliant thanks! I do think the aura and pulse translations help in making these feel more natural, yes.

@cleech cleech merged commit d2f6c9d into cleech:preview-src Mar 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants