Skip anonymous data usage question when running in a non-tty mode

[dgonzalez]

Expected Behavior

Question for anonymous usage statistics should be skippable with a flag or detecting that there is no tty attached (to facilitate docker usage).

Current Behavior

When you run:

 clinic doctor -- node index.js

there is a question prompted that requires interaction:

May Clinic report anonymous usage statistics to improve the tool over time? (Y/n)

Environment

• Clinic version: 2.0.0
• Doctor version: 3.6.0

[mcollina]

@goto-bus-stop can you have a look later this week?

Best way to do this is detecting if process.stdin.tty is false?

[goto-bus-stop]

Ah, i kinda assumed this was handled inside insight . Can prob look into it tomorrow already

[dgonzalez]

Actually wait. From Docker does nor prompt the question, only if it is run from a TTY so yes, works as expected. Excellent work.

[gerkenv]

If you run it from podman (docker alternative).

1. if you call it from CMD step in the dockerfile.
2. When you run container question most-probably appears and container exits with 0 code.

CMD clinic flame -- node index.js

A workaround is to use environment variable NO_INSIGHT with any value.
In this case profiling and server start as expected.

CMD NO_INSIGHT=true clinic flame -- node index.js

According to these lines:

• node-clinic/bin.js

  Lines 273 to 277 in eaa709b

  	if (insight.optOut === undefined) {
  	return promisify(insight.askPermission).call(
  	insight,
  	'May Clinic.js report anonymous usage statistics to improve the tool over time?'
  	)

• node-clinic/bin.js

  Lines 35 to 38 in eaa709b

  	if ('NO_INSIGHT' in process.env) {
  	Object.defineProperty(insight, 'optOut', {
  	get: () => true
  	})

[RafaelGSS]

@gerkenv would you like to include it in the README? That's useful information.

[gerkenv]

I hope it is enough #366