Remove 'resolve' from ordered set #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [clj-commons#71](clj-commons#71). `clojure.core/hash-unordered-coll` has been around since 1.6 and ordered only supports 1.8+ so there's no need to check for its existence anymore.
4 tasks
borkdude
reviewed
May 13, 2024
| ;; We could use compile-if technique here, but hoping to avoid | ||
| ;; an AOT issue using this way instead. | ||
| (def hasheq-ordered-set | ||
| (or (resolve 'clojure.core/hash-unordered-coll) |
Contributor
There was a problem hiding this comment.
This is actually OK on the top level
Contributor
There was a problem hiding this comment.
I thought there was a similar case as with the ordered map, a runtime require, but that's not true it seems
Contributor
There was a problem hiding this comment.
So there is no need for this PR and the bb PR seems good then
Contributor
Author
There was a problem hiding this comment.
Cool, glad to hear the bb PR is unblocked. I think this is a worthwhile change anyway, given that we no longer support the versions the workaround exists for, but I'll wait for some others to take a peek before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #71.
clojure.core/hash-unordered-collhas been around since 1.6 and ordered only supports 1.8+ so there's no need to check for its existence anymore.