Support for the PG wire protocol#2702
Conversation
|
(It looks like this is currently failing tests) |
Yes, the unit test was a spurious network error, the others are problems with the smoke tests that need |
982e1b1 to
25a2a5f
Compare
1881b10 to
08989c7
Compare
0d00322 to
80311ca
Compare
|
@mamcx Hello Mario, this is author of pgwire. Let me know if you have any question with the integration. It's also helpful for me to know if you feel any component that can be or should be upstreamed. |
1569826 to
d806fbb
Compare
3e7e6e4 to
141ea1a
Compare
abae080 to
59306e4
Compare
2dfd505 to
f020df2
Compare
f020df2 to
599d622
Compare
bfops
left a comment
There was a problem hiding this comment.
codeowned changes for me LGTM (crates/cli/src/subcommands/sql.rs)
cloutiertyler
left a comment
There was a problem hiding this comment.
For the two files that I own this looks good to me. I take it we are supporting postgres formatted output and also SpacetimeDB for spacetime sql?
Correct. |
Description of Changes
Closes #2686.
Add support for listening using the PG wire protocol so
pgclients could be used against the database.API and ABI breaking changes
The output of
durationis changed torfc3339, instead of the way is made withsatsbecause is what is done inpg, see note below.Expected complexity level and risk
2
There is open questions that are in the ticket #2686. Also the crate used here require:RustTls, so it could be good idea to decide ifRewrite a big chunk of code to useOpenSSLMove toRustTlsRemove openssl #1700Pay for the extra compilation cost.I open another port(
5433) to listen forpgconnections usingssl. Need to be decided if this is the way or instead try to multi-plex the current port for both protocols.Testing
Only manual testing so far. Solving the above questions allow me to implement some unit tests. Also, not yet integrated into cloud for the same reasons.
psqlthat connect to the db instance and run some queriesjson, duration, etc