Add a recursion limit to the evaluation of type_expr & parse_expr#2935
Merged
Conversation
joshua-spacetime
requested changes
Jul 11, 2025
mamcx
force-pushed
the
mamcx/recursion-limit-expr
branch
3 times, most recently
from
5df9037 to
9e0e9d9
Compare
mamcx
force-pushed
the
mamcx/recursion-limit-expr
branch
2 times, most recently
from
e77fea7 to
e92d223
Compare
joshua-spacetime
approved these changes
Jul 17, 2025
mamcx
force-pushed
the
mamcx/recursion-limit-expr
branch
3 times, most recently
from
cbeabbc to
f136ec0
Compare
mamcx
force-pushed
the
mamcx/recursion-limit-expr
branch
from
f136ec0 to
18ae75e
Compare
mamcx
added a commit
that referenced
this pull request
Aug 26, 2025
) # Description of Changes Add a guard against `stack overflow` in case of nested expression and `joins`. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] Find how `deep` can be recursed the affected functions and put a limit on it - [x] Add a extra test to prove we can (in theory) do lots of `joins` in the planning steps, even if executing them will be slow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add a guard against
stack overflowin case of nested expression andjoins.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
deepcan be recursed the affected functions and put a limit on itjoinsin the planning steps, even if executing them will be slow