V8: add FromValue, error traits, roundtrip tests#2971
Merged
Conversation
gefjon
reviewed
Jul 22, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
One question, then I think we'll be good to merge this.
gefjon
approved these changes
Jul 22, 2025
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The primary goal here is to add the trait
FromValueand its implementation.These are then tested in combination with
ToValue.Some error handling functionality is also added.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Proptests and edge case tests are added, testing that a value
x: Tis the same asfrom_value(to_value(x)).