CI - Check C# quickstart-chat bindings are up to date#2979
Merged
Conversation
…into bfops/check-bindings
rekhoff
approved these changes
Jul 24, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
I see the last test did fail for a lack of regenerated bindings, which if that is accurate then the test is working correctly.
The additional check is clear, concise, and should address the problem. Marking as approved.
Small nit-pick (optional), as this pertains specifically to quickstart-chat, we could be more instructive in the error message to "Please generate bindings for quickstart-chat again...", so it's clear specifically which bindings need to be updated without reviewing the whole log.
Collaborator
Author
|
I updated the error message, good call. Since #2976 is about to merge, I'll wait for that and then merge master into this, so the CI can be green before merging. |
bfops
added a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 task
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A user pointed out (#2976) that our quickstart-chat bindings were out of date in the C# repo. I'm adding a check to the CI to confirm that they are actually up to date, so that this doesn't happen in the future.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing