Abstract SnapshotWorker and durability::Local#4982
Open
Shubham8287 wants to merge 5 commits intomasterfrom
Open
Abstract SnapshotWorker and durability::Local#4982Shubham8287 wants to merge 5 commits intomasterfrom
SnapshotWorker and durability::Local#4982Shubham8287 wants to merge 5 commits intomasterfrom
Conversation
Shubham8287
force-pushed
the
shub/persistence-abstraction
branch
from
8c9bfe0 to
42e55dc
Compare
Shubham8287
changed the title
SnapshotWorker and durability::Local
kim
reviewed
May 8, 2026
|
|
||
| #[cfg(any(feature = "test", test))] | ||
| #[tracing::instrument(level = "trace", skip_all)] | ||
| pub fn try_begin_mut_tx(&self, isolation_level: IsolationLevel, workload: Workload) -> Option<MutTx> { |
Contributor
Author
There was a problem hiding this comment.
yeah, as I have put in description. They are small, trivial and under test flag.
Add a few small API exposure changes under cfg(test) for DST integration.
| } | ||
|
|
||
| pub(crate) fn add_columns_to_table( | ||
| pub(crate) fn add_columns_to_table_mut_tx( |
| } | ||
|
|
||
| #[cfg(any(feature = "test", test))] | ||
| pub fn add_columns_to_table( |
|
|
||
| impl Locking { | ||
| #[cfg(any(feature = "test", test))] | ||
| pub fn try_begin_mut_tx(&self, _isolation_level: IsolationLevel, workload: Workload) -> Option<MutTxId> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Introduce
SnapshotRepoas the snapshot backend trait and decoupleSnapshotWorkerfrom thefilesystem-backed implementation.
dynpattern.Make commitlog
durability::Localgeneric overRepo, so the same durability implementation can bereused with in-memory and fault-injected repositories.
Add a few small API exposure changes under
cfg(test)for DST integration.API and ABI breaking changes
NA.
Expected complexity level and risk
2
Testing
Existing tests should be enough.