Fix view auto-migrate with canonical names#4985
Open
JasonAtClockwork wants to merge 2 commits intomasterfrom
Open
Fix view auto-migrate with canonical names#4985JasonAtClockwork wants to merge 2 commits intomasterfrom
JasonAtClockwork wants to merge 2 commits intomasterfrom
Conversation
Collaborator
|
I think the main issue is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes: #4842
Fixes the auto-migration for views where the exported name differs from the accessor/source name in the validation.
The bug looked like the columns weren't matching and it turned out that the columns were keyed to the accessor name then attempted to match up against the canonical name. That caused the auto-migration to think the columns changed and triggered a remove/add for the view.
API and ABI breaking changes
None intended
Expected complexity level and risk
2 - This is small and targeted but I'm not familiar with this part of the codebase
Testing