Skip to content

Fix segfault in v8 #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coolreader18 merged 2 commits into from
May 9, 2026
Merged

Fix segfault in v8 #4986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1bb6c5
Fix segfault in v8
coolreader18 May 8, 2026
7e03fb6
Merge branch 'master' into noa/fix-v8-segfault
joshua-spacetime May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/core/src/host/v8/syscall/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl ModuleHookKey {
}

/// Context embedder slot holding the receiver (`this`) value used for hook calls.
const RECV_SLOT_INDEX: i32 = ModuleHookKey::SenderErrorClass as i32 + 1;
pub(super) const RECV_SLOT_INDEX: i32 = ModuleHookKey::SenderErrorClass as i32 + 1;

/// Holds the `AbiVersion` used by the module
/// and the module hooks registered by the module
Expand Down
5 changes: 5 additions & 0 deletions crates/core/src/host/v8/syscall/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ pub(super) fn get_hooks<'scope>(
scope: &mut PinScope<'scope, '_>,
exports_obj: Local<'_, v8::Object>,
) -> Result<Option<HookFunctions<'scope>>, ErrorOrException<ExceptionThrown>> {
// We only set RECV_SLOT_INDEX in set_registered_hooks, which is only called in
// the v2 code path. Set it to undefined ahead of time so it's not a garbage value.
scope
.get_current_context()
.set_embedder_data(hooks::RECV_SLOT_INDEX, v8::undefined(scope).into());
if let Some(hooks) = get_registered_hooks(scope) {
return Ok(Some(hooks));
}
Expand Down
Loading