[Cluster] Refactor: Add FinalizeDeleteCluster for async cluster lifecycle management#1673
Open
powerkimhub wants to merge 1 commit into
Open
Conversation
…ptimize Azure AKS driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FinalizeDeleteCluster for Two-Phase Cluster Deletion
DeleteClusterso it only deletes CSP resourcesFinalizeDeleteCluster()to delete Spider meta information only when the cluster no longer exists on CSPNotFoundstatus for clusters that exist in meta but not on CSPDELETE /spider/cluster/{Name}/finalizefor FinalizeDeleteClusterAzure Driver - Async Cluster Operations
Status: Creating(AWS EKS pattern)PollUntilDone, returning afterBeginDeletecallResourceNotFoundlog level from Error to Info (expected during async provisioning)AdminWeb - Fix Zone-less Region Support (e.g., Azure westus)
fetchZone()in vpc-subnet.html to handle undefinedZoneListwith "No Zone Available" fallbackvalidateForm()in vpc-subnet.html to skip zone validation when not requiredshowError()in cluster.html to split on'. 'instead of'.'to preserve version numbers