Remove static data base internal DiskType vailidation of Alibaba#1725
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Alibaba VM creation root disk handling by removing static metadata-based root disk size/type validation before sending RunInstances.
Changes:
- Removed static
cloudos_metaRootDiskSize validation for non-default root disk sizes. - Now forwards
vmReqInfo.RootDiskSizedirectly into the Alibaba ECS request when specified.
Comments suppressed due to low confidence (1)
cloud-control-manager/cloud-driver/drivers/alibaba/resources/VMHandler.go:351
- After removing the metadata-based size checks, the driver no longer validates the requested root disk size against Alibaba's current Min/Max limits even though
DescribeAvailableSystemDisksByInstanceTypealready returns those limits for each supported disk type. This means out-of-range sizes are accepted by the driver and only fail later atRunInstances; replacing the static table check with validation from the dynamic availability response would preserve input validation without relying on stale metadata.
request.SystemDiskSize = vmReqInfo.RootDiskSize
Member
Author
|
I hope this PR can be merged ASAP. |
Member
|
I will be merging this PR for the Tumblebug pre-release. Thank you for your understanding. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve the issue identified from cloud-barista/cm-beetle#356 (comment)
Tested with CB-TB.
💻 g1 ⨉ 1
ALIBABA
ap-northeast-1
Spec: ecs.e-c1m2.large
Image: ubuntu_22_04_x64_20G_alibase_20260316.vhd
vCPU: 2 | Memory: 4GB | Cost: $0.0364/h
rootDiskType:"cloud_essd_entry"
💻 g2 ⨉ 1
ALIBABA
ap-northeast-1
Spec: ecs.c9a.large
Image: ubuntu_22_04_x64_20G_alibase_20260316.vhd
vCPU: 2 | Memory: 4GB | Cost: $0.0906/h
rootDiskType:"cloud_auto"