Skip to content

Remove static data base internal DiskType vailidation of Alibaba#1725

Merged
yunkon-kim merged 1 commit into
cloud-barista:masterfrom
seokho-son:master
May 19, 2026
Merged

Remove static data base internal DiskType vailidation of Alibaba#1725
yunkon-kim merged 1 commit into
cloud-barista:masterfrom
seokho-son:master

Conversation

@seokho-son
Copy link
Copy Markdown
Member

To resolve the issue identified from cloud-barista/cm-beetle#356 (comment)

Tested with CB-TB.

💻 g1 ⨉ 1
ALIBABA
ap-northeast-1
Spec: ecs.e-c1m2.large
Image: ubuntu_22_04_x64_20G_alibase_20260316.vhd
vCPU: 2 | Memory: 4GB | Cost: $0.0364/h

rootDiskType:"cloud_essd_entry"

💻 g2 ⨉ 1
ALIBABA
ap-northeast-1
Spec: ecs.c9a.large
Image: ubuntu_22_04_x64_20G_alibase_20260316.vhd
vCPU: 2 | Memory: 4GB | Cost: $0.0906/h

rootDiskType:"cloud_auto"

Signed-off-by: Seokho Son <shsongist@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Alibaba VM creation root disk handling by removing static metadata-based root disk size/type validation before sending RunInstances.

Changes:

  • Removed static cloudos_meta RootDiskSize validation for non-default root disk sizes.
  • Now forwards vmReqInfo.RootDiskSize directly into the Alibaba ECS request when specified.
Comments suppressed due to low confidence (1)

cloud-control-manager/cloud-driver/drivers/alibaba/resources/VMHandler.go:351

  • After removing the metadata-based size checks, the driver no longer validates the requested root disk size against Alibaba's current Min/Max limits even though DescribeAvailableSystemDisksByInstanceType already returns those limits for each supported disk type. This means out-of-range sizes are accepted by the driver and only fail later at RunInstances; replacing the static table check with validation from the dynamic availability response would preserve input validation without relying on stale metadata.
		request.SystemDiskSize = vmReqInfo.RootDiskSize

@seokho-son
Copy link
Copy Markdown
Member Author

I hope this PR can be merged ASAP.
Related with pre-releases in CB-TB and M-CMP.

@yunkon-kim yunkon-kim merged commit 526f916 into cloud-barista:master May 19, 2026
7 checks passed
@yunkon-kim
Copy link
Copy Markdown
Member

yunkon-kim commented May 19, 2026

I will be merging this PR for the Tumblebug pre-release. Thank you for your understanding.

@seokho-son
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants