Add doc blurb about using fan_out for more summary statistics - #452
Add doc blurb about using fan_out for more summary statistics#452afcollins wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I noticed this actually uncovered a bug or unexpected behavior, so I will update or raise a new PR with the fix. |
991acb8 to
04fbd2b
Compare
|
|
||
| This will return data that looks like the following table output: | ||
| ``` | ||
| time uuid ocpVersion nodeMajorFaults-avg_avg nodeMajorFaults-min_min nodeMajorFaults-max_max |
There was a problem hiding this comment.
The duplication is ugly, but required or else we only get the last result metric.
I have a plan for a fix, but haven't prepared the fix yet, since this is a simple workaround.
| agg: | ||
| agg_type: ${ag} | ||
| fan_out: | ||
| - ag: avg |
There was a problem hiding this comment.
If the key is agg or agg_type it can cause unexpected errors. Maybe we could validate the fan_out block for known keywords?
d522972 to
860edeb
Compare
Signed-off-by: Andrew Collins <ancollin@redhat.com>
860edeb to
b13e560
Compare
1 participant
Type of change
Description
Adds a note about how to use fan_out to collect more stats on a metric.
Checklist before requesting a review