Skip to content

Add ipsec and encrypted filters to generic config metadata - #460

Open
ArthurChenCoding wants to merge 1 commit into
cloud-bulldozer:mainfrom
ArthurChenCoding:upstream-job-filter
Open

Add ipsec and encrypted filters to generic config metadata#460
ArthurChenCoding wants to merge 1 commit into
cloud-bulldozer:mainfrom
ArthurChenCoding:upstream-job-filter

Conversation

@ArthurChenCoding

@ArthurChenCoding ArthurChenCoding commented Aug 12, 2026

Copy link
Copy Markdown
Member

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adds ipsec and encrypted as top-level exact-match metadata filters to the 5 generic workload configs (cluster-density.yaml, crd-scale.yaml, node-density.yaml, node-density-cni.yaml, udn-density-pods.yaml).

These fields filter ES queries by actual cluster configuration, preventing data mixing across job variants (e.g., control-plane vs etcdencrypt vs ipsec) that share the same workload type and scale. The fips field already exists in these configs.

The inline workload orion scripts in the release repo already export ipsec, encrypted, and fips via --input-vars. This PR adds the corresponding template fields so those values are actually used in ES queries.

How it works

Job variant Filter
control-plane (vanilla) ipsec=false, encrypted=false, fips=false
etcdencrypt encrypted=true
ipsec ipsec=true
fips fips=true

Uses Jinja templates with defaults: "{{ ipsec | default('false') }}" and "{{ encrypted | default('false') }}".

Local validation

Tested locally against the QE Elasticsearch instance:

  • No filters (empty ipsec/encrypted/fips): returned 6 results — all from control-plane-fips-24nodes jobs
  • fips=true: returned the same 6 FIPS results (correct positive match)
  • fips=false: returned 0 results (correctly excluded FIPS data)

This confirms the filtering separates job variants as intended.

Supersedes #412

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Local validation against ES (see above)
  • Rehearsal passed on release repo PR (4.23 24-node control-plane test)

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c22e37ca-c858-4b65-a940-d1a8edacdf3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rsevilla87

Copy link
Copy Markdown
Member

/lgtm

@rsevilla87

Copy link
Copy Markdown
Member

/hold

Filters ES queries by cluster configuration (ipsec, encrypted) to
prevent data mixing across job variants (e.g., control-plane vs
etcdencrypt vs ipsec) that share the same workload type and scale.

Uses top-level exact-match metadata fields that describe what the
cluster actually is, rather than filtering by CI job name. The fips
field already exists in these configs.

Defaults to "false" when not set, matching vanilla control-plane runs.

Signed-off-by: ArthurChenCoding <artchen@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Aug 14, 2026
@ArthurChenCoding ArthurChenCoding changed the title Add upstreamJob.keyword filter to generic config metadata Add ipsec and encrypted filters to generic config metadata Aug 17, 2026
@ArthurChenCoding
ArthurChenCoding marked this pull request as ready for review August 17, 2026 16:53
@openshift-ci
openshift-ci Bot requested review from mcornea and mohit-sheth August 17, 2026 16:53
@ArthurChenCoding

ArthurChenCoding commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

@rsevilla87 Hi, can you approve this PR? this PR depends on current PR

@mohit-sheth

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohit-sheth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants