Add ipsec and encrypted filters to generic config metadata - #460
Add ipsec and encrypted filters to generic config metadata#460ArthurChenCoding wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm |
|
/hold |
Filters ES queries by cluster configuration (ipsec, encrypted) to prevent data mixing across job variants (e.g., control-plane vs etcdencrypt vs ipsec) that share the same workload type and scale. Uses top-level exact-match metadata fields that describe what the cluster actually is, rather than filtering by CI job name. The fips field already exists in these configs. Defaults to "false" when not set, matching vanilla control-plane runs. Signed-off-by: ArthurChenCoding <artchen@redhat.com>
ee8dcd5 to
8fe96f0
Compare
|
@rsevilla87 Hi, can you approve this PR? this PR depends on current PR |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohit-sheth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Type of change
Description
Adds
ipsecandencryptedas top-level exact-match metadata filters to the 5 generic workload configs (cluster-density.yaml,crd-scale.yaml,node-density.yaml,node-density-cni.yaml,udn-density-pods.yaml).These fields filter ES queries by actual cluster configuration, preventing data mixing across job variants (e.g., control-plane vs etcdencrypt vs ipsec) that share the same workload type and scale. The
fipsfield already exists in these configs.The inline workload orion scripts in the release repo already export
ipsec,encrypted, andfipsvia--input-vars. This PR adds the corresponding template fields so those values are actually used in ES queries.How it works
ipsec=false,encrypted=false,fips=falseencrypted=trueipsec=truefips=trueUses Jinja templates with defaults:
"{{ ipsec | default('false') }}"and"{{ encrypted | default('false') }}".Local validation
Tested locally against the QE Elasticsearch instance:
control-plane-fips-24nodesjobsfips=true: returned the same 6 FIPS results (correct positive match)fips=false: returned 0 results (correctly excluded FIPS data)This confirms the filtering separates job variants as intended.
Supersedes #412
Related Tickets & Documents
Checklist before requesting a review
Testing