ptfs: refine the way to support O_DIRECT #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have special support of the O_DIRECT flag, but the implementation has race conditions due to `Time To Check & Time To Use` issues. So refine the implementation by using a RwLock. Signed-off-by: Jiang Liu <[email protected]>
If error happens between File::from_raw_fd() and ManuallyDrop::new(), the underlying fd will be closed unexpectedly. Fix it by introducing a helper to ensure atomicity. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
ensure-flags
branch
from
77d506d to
17fb9a6
Compare
jiangliu
requested review from
bergwolf,
eryugey,
imeoer and
liubogithub
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have special support of the O_DIRECT flag, but the implementation has race conditions due to
Time To Check & Time To Useissues. So refine the implementation by using a RwLock.