Refactor df_deployments module - #292
Draft
rsuplina wants to merge 11 commits into
Draft
Conversation
rsuplina
commented
Jun 30, 2026
rsuplina
commented
Contributor
- Added check_deployment_updates to compare only user-provided parameters against current deployment state
- Added build_deployment_update_params to avoid treating module defaults as intentional changes
- Changed cdp_df_client.py to extract WorkloadTransport as a base class with XSRF cookie handling and retry logic
- Changed CdpDfApiClient to handle 308 redirects and DataFlow extension-format payload for flow imports
- Added unit tests for df_deployment module covering create, update, delete, idempotency, and check mode
- Added integration tests for df_deployment module and client with shared fixtures for setup and teardown
Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
…dling Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
… in the codebase Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
…r consistency Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
…parameter and enhance TLS validation handling Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
…ation tests Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
…ault option Signed-off-by: Ronald Suplina <rsuplina@cloudera.com>
This was
linked to
issues
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.