Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Add new API endpoint to install app examples with suitable setup functions #4016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[api] Add new API endpoint to install app examples with suitable setup functions #4016

wants to merge 3 commits into from
+296 −235

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Feb 25, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • Previously, each app had its own /install_example private API which installed example data/tables.
  • Now with this PR change, I've added new public API which can install examples data/tables for supported apps. This will eliminate the need to use the old per app /install_example APIs + its a flexible public API which reduces old dead code.

How was this patch tested?

  • Manually
  • Unit tests

@Harshg999 Harshg999 self-assigned this Feb 25, 2025
@Harshg999 Harshg999 force-pushed the api-install-examples branch from a7829f7 to 1e7e0ac Compare February 25, 2025 17:04
JohanAhlen
JohanAhlen approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@bjornalm bjornalm Awaiting requested review from bjornalm

@ramprasadagarwal ramprasadagarwal Awaiting requested review from ramprasadagarwal

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

@ananya-agarwal ananya-agarwal Awaiting requested review from ananya-agarwal

At least 2 approving reviews are required to merge this pull request.

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harshg999 @JohanAhlen