Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This feature allows using Hue with OIDC, deployed behind https proxy (e.g. on kubernetes, exposed by HttpRoute - which provides SSL). Redirect URL, passed during OIDC autentication has to match with the one registered in application. The problem is that Hue builds dynamically redirect url, using request's protocol (http instead of https), because it doesn't know about proxy. Note that OIDC backend doesn't take into account reverse proxy configuration.
Using OIDC_AUTH_REQUEST_EXTRA_PARAMS it's possible to override token_paylod with correct URL. The same mechanism is used in mozilla_django_oidc, but the parameter wasn't passed from Hue settings, which is fixed by this PR.
Configuration may look like:
'{"redirect_uri" : "https://host/oidc/callback/"}'
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.