refactor(internal): swap to resource and endpoint mapping #776
+1,442
−1,071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we relied on manually mapping the supported resources. This was for a number of reasons: 1. Not all resources supported a `List` operation. 2. Resources were not 1:1 to the API endpoint in Terraform. 3. Resources did not have full attribute coverage and not having a way to flag incomplete resources could result in outages if they were applied. With the release of the Cloudflare Terraform Provider v5 and the SDKs, we're now in a position to make the internals more dynamic as they are all powered by the OpenAPI schemas and eliminates the previously encountered constraints. Under the covers, we have swapped to a mapping file that is generated by an out of band process while the HTTP client and data handling is now using the v4 Go library.
jacobbednarz
force-pushed
the
more-dynamicness
branch
from
83576e9 to
9cc2257
Compare
Updates the generate handler to keep the old way for v4 however, gate the new automatic approach for v5.
jacobbednarz
force-pushed
the
more-dynamicness
branch
from
96e7eb3 to
a940366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on manually mapping the supported resources. This was for a number of reasons:
Listoperation.With the release of the Cloudflare Terraform Provider v5 and the SDKs, we're now in a position to make the internals more dynamic as they are all powered by the OpenAPI schemas and eliminates the previously encountered constraints.
Under the covers, we have swapped to a mapping file that is generated by an out of band process while the HTTP client and data handling is now using the v4 Go library.
To do
Listoperations. Maybe a one off manual mapping and call a freeze on v4?Update the import strings mapping to have a source of truth as well.TBD