Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest 2.6.0 release.
Removes the wasm-pack dependency using wasm-bindgen-cli directly and updates the library wrapper to build the latest API.
The only way this build works is by carefully locking the toolchain back to the snapshot in time when it worked, this is because:
So this gets lolhtml updated, but only in the window that lolhtml still builds on Rust 0.80. That is still going to be a problem in keeping this updated.
As for solving the async model consistency - many of us in wasm-bindgen think these issues can't be solved for asyncify or JSPI - that we are in UB when we apply these models to Wasm code from Rust. One option to get wasm-bindgen updated could be turn off the newer validations, but also just "turning off the validations" isn't really a viable upstream approach without making full sense of the model.
Therefore I would recommend going forward:
For now, this should work completely fine to keep things going.