chore: Derive default for a bunch of types
#1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which either (IMO) have a natural default, or that only consist of `Option`s. This makes initialization of these types less verbose for the user.
LPardue
reviewed
Jan 31, 2025
| @@ -63,7 +64,7 @@ pub enum PacketNumberSpace { | |||
| } | |||
|
|
|||
| #[serde_with::skip_serializing_none] | |||
| #[derive(Clone, Serialize, Deserialize, PartialEq, Eq, Debug)] | |||
| #[derive(Clone, Serialize, Deserialize, PartialEq, Eq, Debug, Default)] | |||
There was a problem hiding this comment.
Open question. For your use case, does default obviate the need for new()?
larseggert
changed the title
default gor a bunch of typesdefault for a bunch of types
|
Don't think so? I mostly want to shorten tings like this: |
|
I interpret that as yes lol. If you're not using new() or with_type() and the |
|
I think |
LPardue
approved these changes
Feb 3, 2025
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which either (IMO) have a natural default, or that only consist of
Options.This makes initialization of these types less verbose for the user.