fix(deploy-suite): create .next/trace before build to avoid ENOENT noise on build failure#1200
Merged
Conversation
…ise on build failure
The Next.js deploy test harness (test/lib/next-modes/base.ts) calls
lstat('.next/trace') during destroy() and throws ENOENT if the file
doesn't exist. vinext doesn't produce a .next/trace (it's a Next.js
telemetry file), so the deploy script creates an empty one as a stub.
That stub was created AFTER 'vinext build' (line ~520), so any run where
the build (or any earlier step like 'pnpm install' / 'vinext init')
failed left .next/trace missing. The test harness then logged ENOENT for
every failed test — 303 lines per deploy-suite workflow run.
Move the stub creation to immediately after the cleanup trap is
installed, before any step that can fail. The cleanup trap runs on EXIT,
so debug artifacts are still preserved; this just ensures .next/trace is
present for the test harness regardless of whether the build succeeded.
Note: VITE_GIT_HOOKS=0 used because vp check --fix errors out when no
JS/TS files are staged (only a .sh file is changed here).
commit: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 303 lines of
Error: ENOENT: no such file or directory, lstat '/tmp/next-test-*/.next/trace'log noise per Next.js deploy-suite workflow run.Root cause
The Next.js deploy test harness (
test/lib/next-modes/base.ts) callslstat('.next/trace')duringdestroy()and throwsENOENTif the file doesn't exist. vinext doesn't produce a.next/trace(it's a Next.js telemetry file), soscripts/e2e-deploy.shcreates an empty stub to satisfy that check.The stub was being created after
vinext buildsucceeded:When the build (or any earlier step —
pnpm install,vinext init, etc.) failed,.next/tracewas never created, and the harness logged ENOENT for every failed test.Fix
Move the stub creation to immediately after the cleanup trap is installed, before any step that can fail. The cleanup trap (
cleanup_on_error) still runs on EXIT and preserves debug artifacts — this only changes when the stub file is created.Verification
scripts/e2e-deploy.shend-to-end. No other path swallows the file's absence; the only producer was the post-buildmkdir/touchpair.cleanup_on_error()andpersist_debug_artifacts()don't touch.next/trace. Belt-and-braces creation there would be redundant since the stub is now created at the very start.bash -nsyntax noise comes from anode -eJS argument and is unrelated to this change.Note on hook bypass
VITE_GIT_HOOKS=0was used for the commit becausevp check --fix(the configured pre-commit task for*invite.config.ts) errors out with "No files found to lint" when only a.shfile is staged. Same workaround other recent shell-only commits inscripts/e2e-deploy.shhistory have hit. Filing a separate issue for the lint task's empty-input behavior is probably worthwhile.