feat(KV): fix statusText in the Workers KV tests #4012
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
teresalves
force-pushed
the
teresalves/kv-fix-tests
branch
from
b57d11c to
d79b5b4
Compare
teresalves
force-pushed
the
teresalves/kv-fix-tests
branch
from
555f388 to
4cc2ccd
Compare
fhanau
approved these changes
May 9, 2025
fhanau
reviewed
May 9, 2025
| }); | ||
|
|
||
| await assert.rejects( | ||
| env.KV.get(['key-not-json', 'key2'], { type: 'banana' }), | ||
| { | ||
| message: 'KV GET_BULK failed: 500 Internal Server Error', | ||
| message: | ||
| 'KV GET_BULK failed: 500 "banana" is not a valid type. Use "json" or "text"', |
There was a problem hiding this comment.
Nit: This needs to be 400 instead of 500, that should get the test (and thus CI checks) to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just improving the already existing KV binding tests