Wrap env in Python DO/WorkerEntrypoint constructor.
#4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/do-env-wrap
branch
from
2cd5c36 to
0eef4df
Compare
|
Can you resolve conflicts? Since we got rid of |
|
The _wrap_subclass is still needed in this case afaik. We need to override the class constructor and that seems to be the way to do it. |
|
Conflicts still need to be resolved. |
dom96
force-pushed
the
dominik/do-env-wrap
branch
from
0eef4df to
d795f64
Compare
|
Resolved. |
dom96
force-pushed
the
dominik/do-env-wrap
branch
from
d795f64 to
9645f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
envis passed via the constructor, this PR ensures that it is wrapped in ourEnvWrapperwhich deals with nice RPC conversions.