-
Notifications
You must be signed in to change notification settings - Fork 373
add WORKERD_ENABLE_ALL_AUTOGATES
env variable
#4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e485f57
to
607163f
Compare
I'm not entirely sure this is the right approach but could be convinced. The key reason is that this potentially misses the various combinations of some-autogates-on-some-autogates-off that could expose bugs and might be missed by this... For instance, the code might work if both autogates A and B are off or both are on, but does it work if only one of the two are on and the other is off? What I think might be better is a bazel configuration that automatically sets up variations of each test for each combination of autogates. That is, if we have three active autogates, then we would have eight test permutations covering each of the various combinations. |
This PR mimics what we have internally, we lack the same detail with our internal tests. |
Should we consider using an environment variable instead, so that we can also run KJ tests with all-autogates?
Unfortunately this doesn't work because it doesn't scale. Even 8x is already probably too much, but in the internal codebase we have 21 autogates defined currently, in addition to the 3 in workerd, that's 24 autogates, so we'd be running each test 16 million times. Granted many of them should probably be cleaned up but still... I think running one with all off and once with all on is a reasonable compromise. Autogates rarely interact with each other in practice. |
I don't have any strong opinion. I'm fine with replacing the cli flag with an environment variable. |
55d6eb2
to
f6d575d
Compare
--all-autogates
cli flagWORKERD_ENABLE_ALL_AUTOGATES
env variable
f6d575d
to
868953d
Compare
5aecb8b
to
9827401
Compare
6e3cd39
to
755e23a
Compare
755e23a
to
f46e788
Compare
f46e788
to
f72b146
Compare
f72b146
to
6a101f1
Compare
Ref: #4089
Adds an environment variable called "WORKERD_ENABLE_ALL_AUTOGATES" which enables all autogates regardless of what's set in the config. This is beneficial for testing.