-
Couldn't load subscription status.
- Fork 462
update node.js streams implementation #5298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The generated output of |
030c4bc to
354d70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look fine except for the fact that this likely needs to be gated with a compat flag and the original behavior preserved, unfortuntely...
To expand a bit: I am not comfortable approving this as it is. There are definitely a number of commits that are semver-major changes in node.js included and given the way this PR was structured (all in one commit where large chunks are moved around and edited without clear diffs of what specifically was changed).. it's not really possible to determine what possible breaking changes are included.
This change is definitely needed, but the PR needs to be restructured to make it easier to review and likely needs to be gated behind a compat flag that preserves the original behavior.
354d70f to
d35af9a
Compare
99fe4c8 to
a8bb8ad
Compare
CodSpeed Performance ReportMerging #5298 will not alter performanceComparing Summary
Footnotes
|
a8bb8ad to
4d384ee
Compare
|
rebasing |
Updates Node.js streams implementation to latest while making it more type-safe.