Skip to content

Reorder fields in cost_report.proto #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented May 27, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Reorder fields in cost_report.proto

Known issue

@ImMin5 ImMin5 requested a review from Copilot May 27, 2025 01:01
@ImMin5 ImMin5 self-assigned this May 27, 2025
@ImMin5 ImMin5 added the bug Something isn't working label May 27, 2025
@ImMin5 ImMin5 merged commit 7e86ba8 into cloudforet-io:master May 27, 2025
3 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders fields in the cost_report.proto file as a bug fix and improvement.

  • Reorders four fields and adjusts their field numbers
  • Updates the proto file to reflect the new order and meet current business requirements
Comments suppressed due to low confidence (1)

proto/spaceone/api/cost_analysis/v1/cost_report.proto:109

  • Reordering fields and changing field numbers (e.g. moving 'cost_report_config_id' from 21 to 25 and 'domain_id' from 25 to 21) may break backward compatibility with existing serialized messages. Consider verifying the impact on clients and providing a proper migration strategy if needed.
string domain_id = 21;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pass/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant