Skip to content

Fix unit test regexes for Ruby 3.4 Hash#inspect format change#222

Merged
neddp merged 1 commit into
masterfrom
fix-ruby34-hash-inspect
Jul 2, 2026
Merged

Fix unit test regexes for Ruby 3.4 Hash#inspect format change#222
neddp merged 1 commit into
masterfrom
fix-ruby34-hash-inspect

Conversation

@neddp

@neddp neddp commented Jul 1, 2026

Copy link
Copy Markdown
Member

Ruby 3.4 changed Hash#inspect to add spaces around => e.g. "key" => "value" instead of "key"=>"value". Update the three log assertion regexes in instance_manager_spec to tolerate optional spaces so they pass on both Ruby 3.3 and 3.4.
Confirmed this unblocks the bump-deps pipeline.

Continuation of #219

Ruby 3.4 changed Hash#inspect to add spaces around => e.g.
"key" => "value" instead of "key"=>"value". Update the three
log assertion regexes in instance_manager_spec to tolerate
optional spaces so they pass on both Ruby 3.3 and 3.4.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This change updates one unit test in instance_manager_spec.rb so the redaction expectations accept optional whitespace around the hash-rocket before <redacted>. It also changes several vendored gem Git LFS pointer files under src/bosh_aws_cpi/vendor/package/, including updated oid/size metadata, added pointer files, and removed pointer contents.

Changes

Area Change
instance_manager_spec.rb Relaxed three redaction expectations to match ?=> formatting
Vendored gem pointers Updated, added, or removed Git LFS pointer metadata for multiple .gem files

Related issues: None specified.

Related PRs: None specified.

Suggested labels: tests, vendor, low-risk

Suggested reviewers: KauzClay, rkoster

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating unit test regexes for the Ruby 3.4 Hash#inspect formatting shift.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description matches the changes by explaining the regex updates for Ruby 3.3/3.4 hash inspect formatting.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ruby34-hash-inspect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 1, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: neddp / name: Ned Petrov (577e063)

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 1, 2026

@aramprice aramprice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw these can probably be removed after the Ruby 3.4 upgrade

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 1, 2026
@neddp neddp merged commit f52df05 into master Jul 2, 2026
6 of 10 checks passed
@neddp neddp deleted the fix-ruby34-hash-inspect branch July 2, 2026 04:15
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants