Fix unit test regexes for Ruby 3.4 Hash#inspect format change#222
Conversation
Ruby 3.4 changed Hash#inspect to add spaces around => e.g. "key" => "value" instead of "key"=>"value". Update the three log assertion regexes in instance_manager_spec to tolerate optional spaces so they pass on both Ruby 3.3 and 3.4.
WalkthroughThis change updates one unit test in Changes
Related issues: None specified. Related PRs: None specified. Suggested labels: tests, vendor, low-risk Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
d0dd9c2 to
577e063
Compare
aramprice
left a comment
There was a problem hiding this comment.
fwiw these can probably be removed after the Ruby 3.4 upgrade
Ruby 3.4 changed Hash#inspect to add spaces around => e.g. "key" => "value" instead of "key"=>"value". Update the three log assertion regexes in instance_manager_spec to tolerate optional spaces so they pass on both Ruby 3.3 and 3.4.
Confirmed this unblocks the bump-deps pipeline.
Continuation of #219